Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate k8s command runner into cluster #1174

Merged
merged 5 commits into from
Aug 29, 2024
Merged

Conversation

carolineechen
Copy link
Collaborator

@carolineechen carolineechen commented Aug 20, 2024

next PRs

  • support additional rsync properties for k8s command runner
  • rename ssh_runner files to generic command runner
  • add k8s docker fixture + tests
  • updating runhouse ssh command (if needed)

Copy link

sentry-io bot commented Aug 20, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: runhouse/resources/hardware/on_demand_cluster.py

Function Unhandled Issue
_populate_connection_from_status_dict ValueError: Sky's cluster status does not have the necessary information to connect to the cluster. Please ch... ...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@carolineechen carolineechen force-pushed the cc/integrate-k8s-runner branch from fc60f2a to 6a53d73 Compare August 20, 2024 19:47
@carolineechen carolineechen force-pushed the cc/add-sky-k8s-runner branch from c9fcbc0 to 110c3ca Compare August 20, 2024 19:52
@carolineechen carolineechen force-pushed the cc/integrate-k8s-runner branch 3 times, most recently from fbdaa57 to 33ae42d Compare August 20, 2024 21:27
@carolineechen carolineechen force-pushed the cc/integrate-k8s-runner branch 2 times, most recently from 025535f to fb09448 Compare August 21, 2024 13:13
@carolineechen carolineechen force-pushed the cc/add-sky-k8s-runner branch 2 times, most recently from cbb0b57 to 7d3fbed Compare August 21, 2024 18:34
@carolineechen carolineechen force-pushed the cc/integrate-k8s-runner branch 3 times, most recently from 35ef9c7 to b0c7b07 Compare August 21, 2024 18:56
@carolineechen carolineechen force-pushed the cc/add-sky-k8s-runner branch from 7d3fbed to d1956b6 Compare August 22, 2024 04:16
@carolineechen carolineechen force-pushed the cc/integrate-k8s-runner branch from b0c7b07 to 1098f89 Compare August 22, 2024 04:16
@carolineechen carolineechen force-pushed the cc/add-sky-k8s-runner branch from d1956b6 to 13f3e7e Compare August 22, 2024 14:14
@carolineechen carolineechen force-pushed the cc/integrate-k8s-runner branch from 1098f89 to d844567 Compare August 22, 2024 14:14
@carolineechen carolineechen force-pushed the cc/add-sky-k8s-runner branch from 13f3e7e to 81213ec Compare August 23, 2024 00:14
@carolineechen carolineechen force-pushed the cc/integrate-k8s-runner branch from d844567 to 5438bd6 Compare August 23, 2024 00:14
@carolineechen carolineechen force-pushed the cc/add-sky-k8s-runner branch from 81213ec to dec7d69 Compare August 23, 2024 00:35
@carolineechen carolineechen force-pushed the cc/integrate-k8s-runner branch from 5438bd6 to a5efa9e Compare August 23, 2024 00:35
Comment on lines +429 to +436
except:
namespace = "default"
pod_name = f"{handle.cluster_name_on_cloud}-head"
self.launched_properties["namespace"] = namespace
self.launched_properties["pod_name"] = pod_name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great

@carolineechen carolineechen marked this pull request as ready for review August 23, 2024 00:38
@carolineechen carolineechen force-pushed the cc/add-sky-k8s-runner branch from dec7d69 to 1e5d42d Compare August 23, 2024 15:39
@carolineechen carolineechen force-pushed the cc/integrate-k8s-runner branch from a5efa9e to 93a7dc2 Compare August 23, 2024 15:39
@carolineechen carolineechen force-pushed the cc/add-sky-k8s-runner branch from 1e5d42d to 9864fc9 Compare August 23, 2024 16:18
@carolineechen carolineechen force-pushed the cc/integrate-k8s-runner branch from 93a7dc2 to 623665f Compare August 23, 2024 16:18
@carolineechen carolineechen force-pushed the cc/add-sky-k8s-runner branch 2 times, most recently from c9233ce to 246f0a1 Compare August 29, 2024 16:19
@carolineechen carolineechen force-pushed the cc/integrate-k8s-runner branch from 623665f to c8c94a1 Compare August 29, 2024 16:19
@carolineechen carolineechen force-pushed the cc/add-sky-k8s-runner branch from 246f0a1 to cd2640f Compare August 29, 2024 16:33
@carolineechen carolineechen force-pushed the cc/integrate-k8s-runner branch from c8c94a1 to 039cc71 Compare August 29, 2024 16:33
@carolineechen carolineechen force-pushed the cc/add-sky-k8s-runner branch 2 times, most recently from 3fdffd5 to a49a04d Compare August 29, 2024 17:24
@carolineechen carolineechen force-pushed the cc/integrate-k8s-runner branch 2 times, most recently from 03afa86 to 121189d Compare August 29, 2024 17:38
@carolineechen carolineechen force-pushed the cc/add-sky-k8s-runner branch from a49a04d to 8fda09b Compare August 29, 2024 17:40
Base automatically changed from cc/add-sky-k8s-runner to main August 29, 2024 17:41
@carolineechen carolineechen force-pushed the cc/integrate-k8s-runner branch 5 times, most recently from 1f9f0e8 to 1d690c5 Compare August 29, 2024 21:13
Copy link
Collaborator Author

carolineechen commented Aug 29, 2024

Merge activity

@carolineechen carolineechen merged commit 0aaa9bb into main Aug 29, 2024
12 checks passed
@carolineechen carolineechen deleted the cc/integrate-k8s-runner branch August 29, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants