Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the env defaulting logic for a module to use the env that it was created in. #1194

Conversation

rohinb2
Copy link
Contributor

@rohinb2 rohinb2 commented Aug 24, 2024

created in.

Copy link
Contributor Author

rohinb2 commented Aug 24, 2024

Copy link
Contributor Author

rohinb2 commented Aug 26, 2024

Merge activity

  • Aug 26, 10:48 AM EDT: @rohinb2 started a stack merge that includes this pull request via Graphite.
  • Aug 26, 10:49 AM EDT: Graphite rebased this pull request as part of a merge.
  • Aug 26, 10:50 AM EDT: @rohinb2 merged this pull request with Graphite.

@rohinb2 rohinb2 force-pushed the 08-24-Improve_the_env_defaulting_logic_for_a_module_to_use_the_env_that_it_was_created_in branch from 52ec3bb to 79a4a1d Compare August 26, 2024 14:49
@rohinb2 rohinb2 merged commit 4e5ce5c into main Aug 26, 2024
10 of 12 checks passed
@rohinb2 rohinb2 deleted the 08-24-Improve_the_env_defaulting_logic_for_a_module_to_use_the_env_that_it_was_created_in branch August 26, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants