Don't call sky refresh during ondemand cluster init #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @carolineechen and the rest of your teammates on |
carolineechen
force-pushed
the
cc/skip-refresh
branch
from
ff609ea to
14c5885
Compare
carolineechen
force-pushed
the
cc/skip-refresh
branch
from
585728c to
0d11b82
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| ) | ||
| if not check_connect_server(): | ||
| raise f"Timed out trying to form connection for cluster {self.name}." |
There was a problem hiding this comment.
The error raising here is missing the ConnectionError exception and uses an f-string without the f prefix. To maintain consistency with other error handling in this method and fix the syntax error, please update the line to:
raise ConnectionError(f"Timed out trying to form connection for cluster {self.name}.")This change will ensure proper exception handling and string formatting.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
dongreenberg
approved these changes
Sep 24, 2024
carolineechen
force-pushed
the
cc/skip-refresh
branch
2 times, most recently
from
79ec7eb to
58a19c2
Compare
carolineechen
force-pushed
the
cc/skip-refresh
branch
from
58a19c2 to
bdad4b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.