Ray Distributor #1305
Merged
Ray Distributor #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @dongreenberg and the rest of your teammates on |
jlewitt1
reviewed
Oct 6, 2024
| @@ -823,6 +823,14 @@ def distribute( | |||
| **distribution_kwargs, name=name, replicas=replicas | |||
| ).to(self.system, env=self.env.name) | |||
| return pooled_module | |||
| elif distribution == "ray": | |||
| from runhouse.resources.distributed.ray_distributed import RayDistributed | |||
There was a problem hiding this comment.
minor nit - for these imports we could do from runhouse.resources.distributed import RayDistributed and add the relevant import to the distributed package __init__
dongreenberg
force-pushed
the
distributed_queue
branch
from
b1aa7c3 to
08045dc
Compare
dongreenberg
force-pushed
the
ray_distributor
branch
2 times, most recently
from
7bef2cd to
97be85d
Compare
dongreenberg
force-pushed
the
distributed_queue
branch
from
08045dc to
fed1456
Compare
dongreenberg
force-pushed
the
ray_distributor
branch
from
97be85d to
329f1ae
Compare
dongreenberg
force-pushed
the
distributed_queue
branch
from
fed1456 to
9364e24
Compare
dongreenberg
force-pushed
the
ray_distributor
branch
from
329f1ae to
654db2a
Compare
dongreenberg
force-pushed
the
distributed_queue
branch
from
9364e24 to
2c95710
Compare
dongreenberg
force-pushed
the
ray_distributor
branch
from
654db2a to
e72c443
Compare
This was referenced Nov 6, 2024
dongreenberg
force-pushed
the
distributed_queue
branch
from
2c95710 to
6beb88f
Compare
dongreenberg
force-pushed
the
ray_distributor
branch
from
e72c443 to
61e5f96
Compare
carolineechen
force-pushed
the
distributed_queue
branch
7 times, most recently
from
2a6eac8 to
7d88a67
Compare
carolineechen
force-pushed
the
ray_distributor
branch
from
61e5f96 to
b313738
Compare
carolineechen
force-pushed
the
distributed_queue
branch
2 times, most recently
from
7bf0dc0 to
1ffc84a
Compare
carolineechen
force-pushed
the
ray_distributor
branch
from
b313738 to
a499ad9
Compare
dongreenberg
force-pushed
the
ray_distributor
branch
from
a499ad9 to
9d9581c
Compare
carolineechen
approved these changes
Nov 13, 2024
dongreenberg
force-pushed
the
distributed_queue
branch
from
9ce92dd to
f47ef9b
Compare
dongreenberg
force-pushed
the
ray_distributor
branch
from
9d9581c to
d5fae63
Compare
dongreenberg
changed the base branch from
distributed_queue
to
graphite-base/1305
dongreenberg
force-pushed
the
ray_distributor
branch
from
d5fae63 to
9257b5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.