Use Pexpect for password clusters instead of paramiko and fsspec #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Migrate object store tests and cluster to use levels instead of ondemand_cpu_cluster - Tests fail due to merging HTTPS changes with docker cluster changes
…g and test setup more thoroughly - Add screen to slim dockerfiles to avoid having to use "--no-screen" - Add default fixture levels to conftest, and module levels override - Give keypair and pwd docker images different tags - Migrate test_module, test_function, and test_obj_store to use `cluster` fixture. Obj store and module tests mostly pass with keypair, and fail for pwd (but pass with pexpect changes in a separate PR)
- Update SSHCommandRunner with SkyPilot's recent updates
…tore tests pass (except known bug in test_stateful_generator) with password cluster.
- Add test_pwd_cluster.py, initial concept for cluster-specific test suite. test_pwd_cluster.py passes (other than one or two known issues) with level MINIMAL.
…g and test setup more thoroughly - Add screen to slim dockerfiles to avoid having to use "--no-screen" - Add default fixture levels to conftest, and module levels override - Give keypair and pwd docker images different tags - Migrate test_module, test_function, and test_obj_store to use `cluster` fixture. Obj store and module tests mostly pass with keypair, and fail for pwd (but pass with pexpect changes in a separate PR)
- Add test_pwd_cluster.py, initial concept for cluster-specific test suite. test_pwd_cluster.py passes (other than one or two known issues) with level MINIMAL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses pexepct to direct passwords to the console for clusters which require them, eliminating fsspec and paramiko from the connection flow, and also giving us a printable string to debug password cluster connection issues with. Everything now flows through the SkyPilot SSHCommandRunner, which I've also updated our fork of.
Also adds an attempt at a simple password test suite. Tests pass for docker and cpu password clusters.
...I have no idea what's going on with the commits. Help.