Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ondemand cluster default creds #1359

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

carolineechen
Copy link
Collaborator

@carolineechen carolineechen commented Oct 30, 2024

perform some extra setup to allow for using your own default creds for ondemand clusters.

  • if ~/.ssh/sky-key exists: do nothing, sky will launch with those creds
  • if ~/.ssh/sky-key does not exist and default_ssh_key exists, copy those creds to ~/.ssh/sky-key so sky can launch with those creds
  • if neither exists, do nothing. sky will create the creds when it launches

note that this does not support passing in custom ssh_creds for ondemand_clusters. it's only for the case of defaulting the sky-key to your default key if you have a default key but no sky key.

Copy link
Collaborator Author

carolineechen commented Oct 30, 2024

Base automatically changed from cc/default-cluster-secret to main October 31, 2024 16:53
@carolineechen carolineechen force-pushed the cc/default-ondemand-secret branch 6 times, most recently from 67ad024 to 83ecf74 Compare November 4, 2024 22:41
@carolineechen carolineechen marked this pull request as ready for review November 4, 2024 23:03
@carolineechen carolineechen force-pushed the cc/default-ondemand-secret branch from 83ecf74 to 871a7de Compare November 5, 2024 16:57
@carolineechen carolineechen force-pushed the cc/default-ondemand-secret branch from 871a7de to 31e46a4 Compare November 5, 2024 17:47
@carolineechen carolineechen merged commit 2e90ae6 into main Nov 5, 2024
9 of 12 checks passed
@carolineechen carolineechen deleted the cc/default-ondemand-secret branch November 5, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants