Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cluster factory #1591

Merged
merged 1 commit into from
Dec 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion runhouse/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
from runhouse.resources.hardware import (
cluster,
Cluster,
kubernetes_cluster,
ondemand_cluster,
OnDemandCluster,
)
Expand Down
2 changes: 1 addition & 1 deletion runhouse/resources/hardware/__init__.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from .cluster import Cluster
from .cluster_factory import cluster, kubernetes_cluster, ondemand_cluster
from .cluster_factory import cluster, ondemand_cluster
from .on_demand_cluster import OnDemandCluster
from .ray_utils import check_for_existing_ray_instance, kill_actors, list_actor_states
from .utils import (
Expand Down
5 changes: 4 additions & 1 deletion runhouse/resources/hardware/cluster.py
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,10 @@ def config(self, condensed: bool = True):

return config

def _update_values(self, new_values: Dict[str, Any]):
for key, val in new_values:
setattr(self, key, val)

def endpoint(self, external: bool = False):
"""Endpoint for the cluster's Daemon server.

Expand Down Expand Up @@ -1072,7 +1076,6 @@ def _start_or_restart_helper(
restart_ray: bool = True,
restart_proxy: bool = False,
):

image_secrets, image_env_vars = self._sync_image_to_cluster()

# If resync_rh is not explicitly False, check if Runhouse is installed editable
Expand Down
Loading
Loading