support custom vpc for den launching #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlewitt1
force-pushed
the
custom-vpc-for-launcher
branch
from
41bb4eb to
3e584db
Compare
jlewitt1
commented
Jan 13, 2025
jlewitt1
force-pushed
the
custom-vpc-for-launcher
branch
2 times, most recently
from
efb3697 to
e8e6be3
Compare
jlewitt1
force-pushed
the
custom-vpc-for-launcher
branch
from
e8e6be3 to
49dc18e
Compare
|
|
||
| You need to create or update the file `~/.sky/config.yaml` to configure | ||
| the VPC. For instance in Amazon Web Services, you need to add | ||
| You can optionally set a `default_vpc` in your `~/.rh/config.yaml` file to specify the default VPC to use |
There was a problem hiding this comment.
just checking that we want to completely remove the docs for local vpc setting through sky config? fine with either way
There was a problem hiding this comment.
oh yea I removed the sky related stuff from those docs also
carolineechen
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.