add info msg to cli output if logs are not available #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlewitt1
reviewed
Jan 16, 2025
runhouse/main.py
Outdated
| @@ -501,8 +501,14 @@ def cluster_logs( | |||
| headers=rns_client.request_headers(), | |||
| ) | |||
|
|
|||
| if ( | |||
| resp.status_code == 404 | |||
| and resp.json().get("detail") == "No logs found for the requested resource" | |||
There was a problem hiding this comment.
do we need to parse the output, don't we know if its a 404 that the logs arent readfy yety?
BelSasha
force-pushed
the
sb/info-msg-for-no-logs
branch
from
34dd406 to
42ece33
Compare
jlewitt1
reviewed
Jan 16, 2025
runhouse/main.py
Outdated
| if resp.status_code != 200: | ||
| console.print("Failed to load cluster logs.") | ||
| console.print(f"Failed to load cluster logs: {resp.json().get('detail')}.") |
There was a problem hiding this comment.
is there any additional info here in the response we would want to expose to a user?
There was a problem hiding this comment.
well it feels like it will be a bit easier to debug it, since the user might just report us the response msg back to us so well get a sense of what went wrong before going though the logs. But I see your point why we should not print it to the user, removing.
BelSasha
force-pushed
the
sb/info-msg-for-no-logs
branch
from
42ece33 to
27c8405
Compare
jlewitt1
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.