Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ssh_cerd values from status #469

Merged
merged 4 commits into from
Feb 13, 2024
Merged

remove ssh_cerd values from status #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4a94fca
remove ssh_creds from status return value
Feb 13, 2024
0ec7753
remove ssh_creds from status return value
Feb 13, 2024
a9ffee6
Merge branch 'main' into sb/remove_ssh_from_status
Feb 13, 2024
405aaee
remove ssh_creds from status return value
Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions runhouse/servers/obj_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1238,6 +1238,7 @@ def status_local(self):

def status(self):
config_cluster = self.get_cluster_config()
config_cluster.pop("ssh_creds", None)
cluster_servlets = {}
for env in self.get_all_initialized_env_servlet_names():
resources_in_env_modified = self.call_actor_method(
Expand Down
2 changes: 2 additions & 0 deletions tests/test_resources/test_clusters/test_cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ def test_rh_here_objects(self, cluster):
def test_rh_status_pythonic(self, cluster):
cluster.put(key="status_key1", obj="status_value1", env="numpy_env")
res = cluster.status()
assert res.get("ssh_certs") is None
assert res.get("server_port") == (cluster.server_port or DEFAULT_SERVER_PORT)
assert res.get("server_connection_type") == cluster.server_connection_type
assert res.get("den_auth") == cluster.den_auth
Expand All @@ -219,6 +220,7 @@ def test_rh_status_cli(self, cluster):
assert "Serving 🍦 :" in res
assert "base_env (runhouse.resources.envs.env.Env):" in res
assert "status_key2 (str)" in res
assert "ssh_certs" not in res

@pytest.mark.skip("Restarting the server mid-test causes some errors, need to fix")
@pytest.mark.level("local")
Expand Down
Loading