Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make env_servlets cache an instance field instead of global. #736

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

rohinb2
Copy link
Contributor

@rohinb2 rohinb2 commented Apr 16, 2024

We don't need this to be global, it's only used in the object store.

In general, minimizing the amount of global stuff we have referencing important objects is better to avoid weird memory issues.

Copy link
Contributor Author

rohinb2 commented Apr 16, 2024

Merge activity

  • Apr 16, 2:02 PM EDT: @rohinb2 started a stack merge that includes this pull request via Graphite.
  • Apr 16, 2:11 PM EDT: Graphite rebased this pull request as part of a merge.
  • Apr 16, 2:12 PM EDT: @rohinb2 merged this pull request with Graphite.

@rohinb2 rohinb2 changed the base branch from rohin/add-helper to main April 16, 2024 18:09
@rohinb2 rohinb2 force-pushed the rohin/move-env-servlet-cache-to-obj-store branch from e42e923 to c10db78 Compare April 16, 2024 18:10
@rohinb2 rohinb2 merged commit 39536fd into main Apr 16, 2024
11 checks passed
@jlewitt1 jlewitt1 deleted the rohin/move-env-servlet-cache-to-obj-store branch April 24, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant