Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker test fixture #830

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Add docker test fixture #830

merged 1 commit into from
Jun 18, 2024

Conversation

carolineechen
Copy link
Collaborator

@carolineechen carolineechen commented May 23, 2024

plus docker cluster specific tests

Copy link
Collaborator Author

carolineechen commented May 23, 2024

@carolineechen carolineechen force-pushed the cc/docker-env branch 2 times, most recently from 0004acb to a4bfe27 Compare May 30, 2024 15:16
@carolineechen carolineechen changed the base branch from cc/docker-env to cc/docker-env-vars May 30, 2024 15:17
@carolineechen carolineechen force-pushed the cc/docker-fixture branch 3 times, most recently from b5e0ced to ee64363 Compare May 30, 2024 19:32
@carolineechen carolineechen force-pushed the cc/docker-fixture branch 2 times, most recently from 02f4095 to 97783ce Compare June 10, 2024 20:01
@carolineechen carolineechen marked this pull request as ready for review June 18, 2024 01:27
@@ -42,6 +42,15 @@ def set_autostop_from_on_cluster_via_cluster_keep_warm():
rh.here.keep_warm()


def torch_exists():
try:
import torch # noqa
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also try creating an array here. Sometimes torch imports but breaks as soon as you try to do anything.

@carolineechen carolineechen force-pushed the cc/docker-env-vars branch 2 times, most recently from cd4b8b4 to 35a46d3 Compare June 18, 2024 20:02
@carolineechen carolineechen force-pushed the cc/docker-fixture branch 2 times, most recently from 057822b to 57fa8fc Compare June 18, 2024 20:11
Base automatically changed from cc/docker-env-vars to main June 18, 2024 20:40
@carolineechen carolineechen merged commit 74614b5 into main Jun 18, 2024
11 checks passed
@carolineechen carolineechen deleted the cc/docker-fixture branch June 18, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants