Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle login error missing private_key key #887

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

mkandler
Copy link
Contributor

@mkandler mkandler commented Jun 11, 2024

Handling secret syncing more gracefully to resolve this error from running runhouse login

Retrieve your token 🔑 here to use 🏃 🏠 Runhouse for secrets and artifact management: https://run.house/account#token
Token: 
Download your Runhouse config to your local .rh folder? [Y/n]: y
Download secrets from Vault to your local Runhouse environment? [y/N]: y
Upload your local .rh config to Runhouse? [y/N]: y
Upload your local enabled provider secrets to Vault? [y/N]: y
INFO | 2024-06-07 16:13:03.070479 | Loaded Runhouse config from /Users/matthewkandler/.rh/config.yaml
yINFO | 2024-06-07 16:13:03.655838 | Saving config for ssh-sky-key to Den
INFO | 2024-06-07 16:13:03.784929 | Saving secrets for ssh-sky-key to Vault
INFO | 2024-06-07 16:13:04.464916 | Loading down secrets for ssh-sky-key into ~/.ssh
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/matthewkandler/miniconda3/envs/llama3-rh/lib/python3.9/site-packages/runhouse/rns/login.py", line 142, in login
    _login_download_secrets(from_cli=from_cli)
  File "/Users/matthewkandler/miniconda3/envs/llama3-rh/lib/python3.9/site-packages/runhouse/rns/login.py", line 165, in _login_download_secrets
    secret.write(path=download_path)
  File "/Users/matthewkandler/miniconda3/envs/llama3-rh/lib/python3.9/site-packages/runhouse/resources/secrets/provider_secrets/provider_secret.py", line 128, in write
    return self._write_to_file(path, values=self.values, overwrite=overwrite)
  File "/Users/matthewkandler/miniconda3/envs/llama3-rh/lib/python3.9/site-packages/runhouse/resources/secrets/provider_secrets/ssh_secret.py", line 90, in _write_to_file
    priv_key_path.write_text(values["private_key"])
KeyError: 'private_key'

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mkandler and the rest of your teammates on Graphite Graphite

@mkandler mkandler force-pushed the 06-11-handle_login_error_missing_private_key_key branch 2 times, most recently from 8352bfe to c0f3862 Compare June 11, 2024 16:24
@mkandler mkandler force-pushed the 06-11-handle_login_error_missing_private_key_key branch from c0f3862 to 2b021a0 Compare June 14, 2024 16:34
@mkandler mkandler merged commit 37dbad8 into main Jun 25, 2024
12 checks passed
@mkandler mkandler deleted the 06-11-handle_login_error_missing_private_key_key branch June 25, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant