Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Initial commit of the Mintter Publications Reader - Returns an error #927

Closed
wants to merge 1 commit into from

Conversation

elsatch
Copy link

@elsatch elsatch commented Feb 5, 2024

Description

This loader connects to the Mintter local daemon to extract hypertext documents into LlamaIndex.

For additional information about Mintter: https://github.com/MintterHypermedia/mintter

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • New Loader/Tool
  • Bug fix / Smaller change
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I have tried to run this tool locally using the test.py file, but got an error:
File "e:\dev\contrib\llama-hub\llama_hub\mintter\test.py", line 7, in
MintterPublicationsReader = download_loader('MintterPublicationsReader')
File "E:\dev\contrib\llama-hub.venv\lib\site-packages\llama_index\readers\download.py", line 49, in download_loader
reader_cls = download_llama_module(
File "E:\dev\contrib\llama-hub.venv\lib\site-packages\llama_index\download\module.py", line 217, in download_llama_module
module_info = get_module_info(
File "E:\dev\contrib\llama-hub.venv\lib\site-packages\llama_index\download\module.py", line 71, in get_module_info
raise ValueError("Loader class name not found in library")
ValueError: Loader class name not found in library

I assume my module is not being recognized locally because of some misconfiguration error. After asking on the contributing channel of LlamaIndex discord, I was asked to submit the PR for review.

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense
  • I restarted my environment and the error persisted

Suggested Checklist:

  • I have added a library.json file if a new loader/tool was added
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@elsatch elsatch closed this Feb 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant