Fix - Google Drive Issue of not loading same name files #12022
Merged
+14
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
The modification here aims to resolve an issue with the Google Drive loader. When there are multiple files with the same name in your folder, not all files are retrieved. This happens because the loader uses the filename for downloading, causing files to be overwritten.
In this Pull Request, we've shifted from using the filename to using the file ID, ensuring uniqueness and proper functionality.
Version Bump?
Did I bump the version in the
pyproject.toml
file of the package I am updating? (Except for thellama-index-core
package)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
This update, which connects to Google, should be covered by existing tests. However, if you wish to test it yourself, I've added a 'folder_id' with 15 files. The previous code would return 10 files, but now it will return all 15. Additionally, I have included regular tests for all readers in the Google folder.
You can run the following code for testing:
PS: if someone write a mock tests for this would be appreciated.
Suggested Checklist:
make format; make lint
to appease the lint gods