Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax llama-parse version #12232

Closed
wants to merge 1 commit into from
Closed

Conversation

cbornet
Copy link
Contributor

@cbornet cbornet commented Mar 25, 2024

Description

Llama-index pulls llama-parse through llama-index-readers-llama-parse.
The llama-index code doesn't use llama-parse so there is no reason to limit the version of llama-parse that can be used.
The only limitation would be on the version of llama-core but that will be resolved by the package manager.
For instance it's currently not possible to use llama-parse 0.4 with llama-index 0.10.23 although there is no reason for that.

Type of Change

Enhancement

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 25, 2024
@logan-markewich
Copy link
Collaborator

Hey @cbornet thanks for the heads up. I actually just merged a similar fix -- should be published and good to go
#12236

@cbornet
Copy link
Contributor Author

cbornet commented Mar 25, 2024

Yes I’ve seen the other fix from my co-worker Nicolo 😄.
The problem is that we’ll face the same issue at the next release of llama-parse.
So I think it’s better to really relax the version range.

@logan-markewich
Copy link
Collaborator

logan-markewich commented Mar 27, 2024

The next releases would only be a patch, x.y.z only changing z

Generally if we change y, that's a more major change that may require code changes to work, and should be a bit more careful around

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants