Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CorrectiveRAG Notebook Error fixes #16422

Merged

Conversation

tevfikcagridural
Copy link
Contributor

Description

ctx.get("relevancy_pipeline").run(... and ctx.get("tavily_tool").search(... raises AttributeError. Corrected with first intantiating and then running.
Also fixed SyntaxError on if not (index or tavily_tool) line 111 cell 6.

Fixes #16421

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • [-] No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • [-] No

Type of Change

Please delete options that are not relevant.

  • [-] This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • [-] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • [-] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

…earch(...` raises `AttributeError`. Corrected with first intantiating and then running. Also fixed `SyntaxError` on `if not (index or tavily_tool)`.
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 8, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 8, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) October 8, 2024 21:24
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Oct 8, 2024
@logan-markewich logan-markewich merged commit e84883f into run-llama:main Oct 8, 2024
11 checks passed
@tevfikcagridural tevfikcagridural deleted the corrective_rag_notebook_fix branch October 8, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation]: CorrectiveRAG Notebook Errors
2 participants