Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Astra DB integration for API changes #9193

Merged
merged 4 commits into from
Nov 29, 2023

Conversation

erichare
Copy link
Contributor

Description

This adds metadata filtering and MMR query mode support for the Astra DB integration. It also updates the existing integration to support a change to the server-side Astra JSON API.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@erichare erichare marked this pull request as ready for review November 29, 2023 01:20
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 29, 2023
@erichare
Copy link
Contributor Author

@nerdai We have another Astra DB update - this extends some of the functionality of the integration and fixes one issue with respect to an API update on the Astra DB server. Thanks so much.

Copy link
Contributor

@nerdai nerdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really great -- thanks!!!

@nerdai nerdai merged commit e1d513d into run-llama:main Nov 29, 2023
8 checks passed
thomas0809 pushed a commit to voyage-ai/llama_index that referenced this pull request Nov 30, 2023
* Update Astra DB integration for API changes

* Update astra.py

* Fix issue in specification of metadata filter
@erichare erichare deleted the astra-integration-fixes branch November 30, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants