DB Safety feature and GCP opta destroy + config upload

[juandiegopalomino]

1. GCP and AWS dbs now have enable deletion protection enabled when possible, making the owners apply at least once with safety false before being able to destroy the dbs. This obvious safety feature would be much for prevalent if not for this stupid 2.5 year old bug which people are still begging for: "Variables may not be used here" for prevent_destroy hashicorp/terraform#22544
2. Opta configs are uploaded to cloud storage bucket for gcp too
3. Opta destroy now destroys services before environment for gcp too. And no special cases needed to be handled lol!

[kevjin]

what happens when a customer tries to run opta destroy when safety is enabled? does the terraform destroy fail unsafely midway?
A big part of the reason we initially wanted to support rollback, was to recover terraform state that is commonly lost when apply/destroy fails hard.

[juandiegopalomino]

what happens when a customer tries to run opta destroy when safety is enabled? does the terraform destroy fail unsafely midway?
A big part of the reason we initially wanted to support rollback, was to recover terraform state that is commonly lost when apply/destroy fails hard.

That's a great question Kevin. So as it stands it will fail harshly with opta apply needing to be run again w/ safety on before destroying again (the state should not be mangled though). An update on this would be to catch the error beforehand and fail elegantly, which we can do in a follow up pr

[codecov]

Codecov Report

Merging #163 (bc67aa5) into main (476442a) will decrease coverage by 0.84%.
The diff coverage is 34.14%.

@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
- Coverage   76.27%   75.43%   -0.85%     
==========================================
  Files          39       39              
  Lines        2112     2149      +37     
==========================================
+ Hits         1611     1621      +10     
- Misses        501      528      +27     

Flag	Coverage Δ
unittests	75.43% <34.14%> (-0.85%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
opta/commands/apply.py	78.94% <25.00%> (-3.00%)	⬇️
opta/core/gcp.py	43.24% <33.33%> (-11.76%)	⬇️
opta/commands/destroy.py	61.53% <36.84%> (-11.94%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 476442a...bc67aa5. Read the comment docs.