Do nothing when sns topic is not provided (#117)

runatlantis · Sep 27, 2021 · 0d3d8b6 · 0d3d8b6
1 parent df78401
commit 0d3d8b6
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 6 deletions.
diff --git a/server/lyft/aws/sns/writer.go b/server/lyft/aws/sns/writer.go
@@ -16,6 +16,10 @@ type Writer interface {
 	Write([]byte) error
 }
 
+func NewNoopWriter() Writer {
+	return &noopWriter{}
+}
+
 // NewWriterWithStats returns a new instance of Writer that will connect to the specifed
 // sns topic using the specified session
 func NewWriterWithStats(
@@ -30,7 +34,6 @@ func NewWriterWithStats(
 			topicArn: aws.String(topicArn),
 		},
 	}
-
 }
 
 type writer struct {
@@ -64,3 +67,9 @@ func (w *writerWithStats) Write(payload []byte) error {
 	w.scope.NewCounter(metrics.ExecutionSuccessMetric)
 	return nil
 }
+
+type noopWriter struct{}
+
+func (n *noopWriter) Write(payload []byte) error {
+	return nil
+}
diff --git a/server/server.go b/server/server.go
@@ -591,11 +591,17 @@ func NewServer(userConfig UserConfig, config Config) (*Server, error) {
 		return nil, errors.Wrap(err, "initializing new aws session")
 	}
 
-	snsWriter := sns.NewWriterWithStats(
-		session,
-		userConfig.LyftAuditJobsSnsTopicArn,
-		statsScope,
-	)
+	var snsWriter sns.Writer
+
+	if userConfig.LyftAuditJobsSnsTopicArn != "" {
+		snsWriter = sns.NewWriterWithStats(
+			session,
+			userConfig.LyftAuditJobsSnsTopicArn,
+			statsScope,
+		)
+	} else {
+		snsWriter = sns.NewNoopWriter()
+	}
 
 	auditProjectCmdRunner := &lyftDecorators.AuditProjectCommandWrapper{
 		SnsWriter:            snsWriter,