Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide comments in github enterprise is still broken #1108

Closed
grimm26 opened this issue Jul 9, 2020 · 6 comments
Closed

Hide comments in github enterprise is still broken #1108

grimm26 opened this issue Jul 9, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@grimm26
Copy link
Contributor

grimm26 commented Jul 9, 2020

The CHANGELOG mentions that #1072 @goodspark fixed --hide-prev-plan-comments on GHE. It did, but that PR was almost immediately trashed by commits that were brought in on the same day: https://github.com/runatlantis/atlantis/commits/master/server/events/vcs/github_client.go

I have opened #1107 to replace the fix or if something about my PR isn't right, someone else please do it. A patch release to actually put this fix out that was said to be in v0.14.0 would be nice, too.
@lkysow
Copy link
Member

lkysow commented Jul 9, 2020

Hey thanks for investigating this, sorry that that happened. Yes we'll do a patch release.

@lkysow lkysow added the bug Something isn't working label Jul 9, 2020
@lkysow lkysow mentioned this issue Jul 9, 2020
Merged
@lkysow
Copy link
Member

lkysow commented Jul 9, 2020

Closed by #1107

@lkysow lkysow closed this as completed Jul 9, 2020
@lkysow
Copy link
Member

lkysow commented Jul 9, 2020

@grimm26 can you verify with runatlantis/atlantis:latest before I release? I don't have GHE to test with.

@grimm26
Copy link
Contributor Author

grimm26 commented Jul 9, 2020

@lkysow will do in a bit

@grimm26
Copy link
Contributor Author

grimm26 commented Jul 9, 2020

@lkysow it works!

@lkysow
Copy link
Member

lkysow commented Jul 9, 2020

okay awesome, I'll get out a patch release along with #1109

@grimm26 grimm26 mentioned this issue Jul 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grimm26 @lkysow