Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back clobbered hide-prev-commentds fix #1107

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Bring back clobbered hide-prev-commentds fix #1107

merged 1 commit into from
Jul 9, 2020

Conversation

grimm26
Copy link
Contributor

@grimm26 grimm26 commented Jul 9, 2020

Bring back change from 2f07472#diff-e348084f0b7562996b0bd5d429158e53
that was clobbered.

@lkysow
Copy link
Member

lkysow commented Jul 9, 2020

Ack sorry about that. The tests are failing as well.

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #1107 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1107   +/-   ##
=======================================
  Coverage   70.91%   70.91%           
=======================================
  Files          71       71           
  Lines        5876     5876           
=======================================
  Hits         4167     4167           
  Misses       1362     1362           
  Partials      347      347           
Impacted Files Coverage Δ
server/events/vcs/github_client.go 79.68% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59fcd86...caf3319. Read the comment docs.

@lkysow lkysow merged commit 1944657 into runatlantis:master Jul 9, 2020
@lkysow
Copy link
Member

lkysow commented Jul 9, 2020

Closes #1108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants