Atlantis should log a warning if custom gitlab or github hostname isn't resolvable by DNS.

[lkysow]

#122 took a while to debug because there wasn't a good error message. When Atlantis starts up, we should validate whether we can resolve any custom gitlab or github hostname and if not, log a warning.

[majormoses]

On the flip side if you are spinning up a gitlab which is I believe often packaged as a container now it may not be immediately resolvable if your containers launch too close to each other depending on your setup, I'd suggest better logging and an option to bail on failure to connect (or an option to keep running whichever makes more sense) also keep in mind that if you are using a process supervisor such as systemd, upstart, runit, etc its very likely you have set it to auto restart on failures.

[lkysow]

I think you should still be able to resolve the DNS though? If you're using something like Docker Compose I think that the DNS is set even if the container isn't booting yet.

[majormoses]

There is a very long thread on this as it related to elasticsearch: elastic/elasticsearch#14441 feel free to read through all the reasons that people gave. It is a bit different in that it is ips vs names but I think the concept is the same. We could always eat our cake and eat it by using config/args to control this behavior.

[lkysow]

Okay I'll change this to logging a warning if it can't resolve it.

[majormoses]

I'd be ok with warning or error. Id personally steer towards errors.

[lkysow]

In GitHub this is not needed:

Making pull request API call to GitHub: Get https://lsdlsjkd/api/v3/repos/lkysow/atlantis-example/pulls/15: dial tcp: lookup lsdlsjkd: no such host