Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate releases without a manual PR prior to release #2912

Closed
1 task done
nitrocode opened this issue Jan 3, 2023 · 0 comments · Fixed by #3049 or #3051
Closed
1 task done

Automate releases without a manual PR prior to release #2912

nitrocode opened this issue Jan 3, 2023 · 0 comments · Fixed by #3049 or #3051
Labels
build Relating to how we build Atlantis

Comments

@nitrocode
Copy link
Member

nitrocode commented Jan 3, 2023 •
edited
Loading

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Describe the user story

I'd like to automate releases without making manual changes

Describe the solution you'd like

Instead of hard coding three version, let's pass in the version using an ldflag via goreleaser

See https://github.com/cloudposse/atmos/blob/3a43ea01e4704705a23afae861931e07bafdfc8d/cmd/version.go#L8 (their default is 0.0.1, ours can be build or local) and https://github.com/cloudposse/atmos/blob/3a43ea01e4704705a23afae861931e07bafdfc8d/.goreleaser.yml#L27 for inspiration.

For the kustomize bundle, let's just use latest since that is already tied to the latest stable release.

Scenarios after completion

  • PR merge - should result in version dev-<7 char git ref>.
  • prerelease and release - results in version with same tag name

Currently above scenarios will return hard coded value from code

Here is where we currently document our current manual release pr steps

https://github.com/runatlantis/atlantis/blob/main/CONTRIBUTING.md#creating-a-new-release

Describe the drawbacks of your solution

None

Describe alternatives you've considered

None
@nitrocode nitrocode added the feature New functionality/enhancement label Jan 3, 2023
@nitrocode nitrocode mentioned this issue Jan 13, 2023
Merged
@nitrocode nitrocode changed the title Automate releases without a PR Automate releases without a manual PR prior to release Jan 21, 2023
@nitrocode nitrocode added build Relating to how we build Atlantis and removed feature New functionality/enhancement labels Jan 25, 2023
@nitrocode nitrocode mentioned this issue Jan 26, 2023
Merged
1 task
@nitrocode nitrocode mentioned this issue Jan 26, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Relating to how we build Atlantis
Projects
None yet
Milestone
No milestone
1 participant
@nitrocode