-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docker): Set version based on release tag, revert gorelease signing #3051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
build
Relating to how we build Atlantis
github-actions
go
Pull requests that update Go code
labels
Jan 26, 2023
nitrocode
changed the title
fix(docker): Set version based on github release tag
fix(docker): Set version based on release tag, revert gorelease signing
Jan 26, 2023
jamengual
approved these changes
Jan 26, 2023
After cutting the release, we can see the new version propagate to the command line. ✗ docker pull ghcr.io/runatlantis/atlantis:v0.23.0-pre.20230125
✗ docker run --rm -it ghcr.io/runatlantis/atlantis:v0.23.0-pre.20230125 version
atlantis v0.23.0-pre.20230125 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
workflow_dispatch
torelease
actiongithub
config is omittedwhy
dev
instead of the tag passed to itrelease
action can now be run manually to correct a broken tag (like the current one) without having to create a brand new releasenotes
dev
and the release tag but it's a bit difficult since not all of the code uses the meta action yet. This will have to be done in another ticket. Filed a separate ticket for this. Sign all goreleaser builds #3053tests
Testing...
on pr merge action run and notable expected build-args and tags from
Build and push (for dev)
on pre-release action run and notable expected build-args and tags from
Build and push (for pre-release)
references
main
0.23.0-pre.20230125
0.22.3