Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Devops - UI issue in comments #854

Closed
mcdafydd opened this issue Nov 22, 2019 · 4 comments · Fixed by #863
Closed

Azure Devops - UI issue in comments #854

mcdafydd opened this issue Nov 22, 2019 · 4 comments · Fixed by #863

Comments

@mcdafydd
Copy link
Contributor

Now that things are working I noticed a minor UI issue when atlantis comments on the PR; it looks like azure devops doesn't support emojis so we see the alt text instead. Doesn't bother me but could make things look prettier:
bug

Originally posted by @jimmyjamesbaldwin in #849 (comment)

Opening an issue to research this further. I assumed that it was not supported either, but just found a recent Microsoft doc indicating that pull requests and wikis should support the full range of emojis now. So possibly there's an issue with the API version we're using in Atlantis pull request comments or maybe it has something to do with the blackfriday.v2 conversion we're doing before posting the comment.

@mcdafydd
Copy link
Contributor Author

IIRC, I added the blackfriday conversion early on when posting to Work Items instead of pull requests because the resulting comment formatting didn't look very good without it.

I just removed the conversion and the resulting comment actually looks a lot better now, and the emojis seem to work.

Screen Shot 2019-11-22 at 8 48 36 AM

I'll run with this for a bit and make sure there are no other issues with the workflow. If I don't run into any issues or hear any comments about why we should leave the blackfriday conversion in place, I will submit a PR to remove it.

@lkysow
Copy link
Member

lkysow commented Nov 27, 2019

I think remove it!

@mcdafydd
Copy link
Contributor Author

Sounds good to me! I'll get something together.

@lkysow
Copy link
Member

lkysow commented Dec 4, 2019

@mcdafydd can you DM on Twitter (https://twitter.com/lkysow) or on the Atlantis Slack? I'd like to get in touch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants