Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to disable autoplan from server config #1071

Closed

Conversation

ValdirGuerra
Copy link
Contributor

@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #1071 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1071      +/-   ##
==========================================
+ Coverage   71.49%   71.51%   +0.01%     
==========================================
  Files          67       67              
  Lines        5564     5567       +3     
==========================================
+ Hits         3978     3981       +3     
  Misses       1272     1272              
  Partials      314      314              
Impacted Files Coverage Δ
cmd/server.go 79.72% <ø> (ø)
server/user_config.go 100.00% <ø> (ø)
server/events/command_runner.go 44.25% <100.00%> (+0.37%) ⬆️
server/server.go 61.94% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e0f265...77f6cd8. Read the comment docs.

Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a naming suggestion.

cmd/server.go Outdated Show resolved Hide resolved
cmd/server.go Show resolved Hide resolved
@ValdirGuerra ValdirGuerra changed the title Adding support for disable autoplan from server config Adding support to disable autoplan from server config Aug 4, 2020
@lkysow
Copy link
Member

lkysow commented Aug 18, 2020

Merged in #1159. Thanks!

@lkysow lkysow closed this Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants