-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Version to /healthz endpoint #1120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, one more change to use snake_case.
Also I missed this but we talked about it being on /status
not /healthz
Co-authored-by: Luke Kysow <1034429+lkysow@users.noreply.github.com>
Co-authored-by: Luke Kysow <1034429+lkysow@users.noreply.github.com>
Hm I'd like to put the changes in the StatusController and see this file but it doesn't have access to the Server. How would I go about moving these changes from the atlantis/server/status_controller.go Line 24 in 909723f
Sorry. I'm a bit of a golang noob. |
No worries, so you'll need to add statusController := &StatusController{
Logger: logger,
Drainer: drainer,
AtlantisVersion: config.AtlantisVersion,
} The in the status_controller it will be available on the struct pointer, e.g. data, err := json.MarshalIndent(&StatusResponse{
ShuttingDown: status.ShuttingDown,
InProgressOps: status.InProgressOps,
AtlantisVersion: d.AtlantisVersion,
}, "", " ") |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Closes #1119