Fix bug with top-level modules/ directory. #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #12. Previously we would assume that if there was a change in any modules/ directory, we should run plan in the parent. Now we first check whether the parent has a main.tf file. If it doesn't then we assume it's not actually the root of a project.
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
==========================================
+ Coverage 63.63% 63.77% +0.14%
==========================================
Files 38 38
Lines 1771 1778 +7
==========================================
+ Hits 1127 1134 +7
Misses 593 593
Partials 51 51
Continue to review full report at Codecov.
|
This was referenced Feb 28, 2018
ghaiszaher
referenced
this pull request
in ghaiszaher/atlantis
Oct 7, 2022
* Dequeue next on Atlantis unlock * Dequeue next on PR cleanup (e.g. after closing) * Quick fix * Fix * Reworked the TODOs, docu and a bit of refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12. Previously we would assume that if there was a change
in any modules/ directory, we should run plan in the parent. Now
we first check whether the parent has a main.tf file. If it doesn't
then we assume it's not actually the root of a project.