Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Azure DevOps get modified files from PR via source -> target diff #1568

Merged
merged 1 commit into from
May 11, 2021
Merged

fix: Azure DevOps get modified files from PR via source -> target diff #1568

merged 1 commit into from
May 11, 2021

Conversation

mhennecke
Copy link
Contributor

My first attempt of fixing #1397 lead to issues, where later commits in an Azure DevOps PR revert changes to some modules introduced in earlier commits.

This PR reverts #1521 and gets modified files from the diff of the PRs source branch to the target branch instead of just the latest commit.

@mhennecke mhennecke requested a review from a team as a code owner May 8, 2021 23:28
@mhennecke
Copy link
Contributor Author

any idea, why the "website_link_check" fails?

@acastle
Copy link
Contributor

acastle commented May 10, 2021

The website_link_check test can be flaky whenever the sites we link to are having issues or change their content. This has been fixed in master, you will need to rebase for the CI checks to succeed.

@mhennecke
Copy link
Contributor Author

Got it. Branch is rebased. Checks look good now.

Copy link
Contributor

@acastle acastle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you for the fix!

@acastle acastle merged commit 40ffdd1 into runatlantis:master May 11, 2021
@mhennecke mhennecke deleted the fix-1397-2 branch May 17, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants