Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ParallelPlan and ParallelApply out of order in buildProjectCommandCtx #1574

Merged
merged 5 commits into from
May 10, 2021
Merged

Fix ParallelPlan and ParallelApply out of order in buildProjectCommandCtx #1574

merged 5 commits into from
May 10, 2021

Conversation

Fauzyy
Copy link
Contributor

@Fauzyy Fauzyy commented May 10, 2021

Description

This PR fixes a recently introduced regression. The ProjectCommandContextBuilder interface has the parallelApply, parallelPlan args in the wrong order from which they're actually used. As a result they were recently swapped in buildProjectCommandCtx

The result is that setting parallel_plan=true will instead runs applies in parallel, and vice versa.

Testing

  • Tested this in local dev
  • Added unit test to verify we're setting the right values in BuildProjectContext and buildProjectCommandCtx

@Fauzyy Fauzyy requested a review from a team as a code owner May 10, 2021 17:17
@Fauzyy Fauzyy changed the title Fauzyy/parallel out of order ParallelPlan and ParallelApply out of order in buildProjectCommandCtx May 10, 2021
@Fauzyy Fauzyy changed the title ParallelPlan and ParallelApply out of order in buildProjectCommandCtx Fix ParallelPlan and ParallelApply out of order in buildProjectCommandCtx May 10, 2021
acastle
acastle approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@acastle acastle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bug fix that comes with test coverage ❤️

Thanks for your contribution @Fauzyy !

@acastle acastle merged commit d98474a into runatlantis:master May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acastle acastle acastle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fauzyy @acastle