-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a pending status for apply when running plan command #2053
feat: add a pending status for apply when running plan command #2053
Conversation
…heck if the PR is mergeable like the doc next to it says
I'm running with no problems for more than a month, can someone review please? |
@chenrui333 could you please review this 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!!
@AndreZiviani thanks for the work on this. 🙏 Gonna cut a new release today! |
@AndreZiviani is there any configuration required to sue this new functionality? This sounds like exactly what we've been looking for - we want CODEOWNERS to be required before you can apply AND want to make atlantis/apply required. |
Hey @rayterrill these are my branch protection rules, working perfectly so far |
This feature completely broke our workflow in Github Actions where we relied on https://github.com/WyriHaximus/github-action-wait-for-status to continue. |
@AndreZiviani I think this might have broken the status for all other VCS implementations: look this please #2138 if we do not hear from you soon I will revert this change since is affecting quite a lot of people. |
@jamengual sorry my change broke other workflows :( |
@AndreZiviani this is affecting github users as well so I think we need to revert it back then we can have a prerelease with this feature after you get feedback from people that this is working for them too, unless you can test in other VCSs by yourself. |
I agree that a rollback is necessary, I will try to gather feedback and improve this on the following days |
…lantis#2053) * add a pending status for apply when running plan command * fix status updater logic, we should only update the status after we check if the PR is mergeable like the doc next to it says * do not dismiss the PR if the only our "atlantis/apply" status is pending/failing * fix logic and tests * linting
This PR adds the following improvements:
plan
command is issued (including autoplan), this allows to configure the repository to only be mergeable if atlantis applied all changesatlantis/apply
status is pending/failing consider the PR mergeableWith these changes we can configure the GitHub repository to only be mergeable if: all status succeed, at least 1 approval from CODEOWNERS and only allow merging after atlantis is finished
Fix #1924, Fix #1791