Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for failing builds #2284

Merged
merged 2 commits into from
Jun 4, 2022
Merged

Fix for failing builds #2284

merged 2 commits into from
Jun 4, 2022

Conversation

csainty
Copy link
Contributor

@csainty csainty commented May 30, 2022

I noticed builds failing, for two separate issues.

The install script location for golangci-lint has been changed, you can see the new one in their docs - https://golangci-lint.run/usage/install/#other-ci

docs.github.com seems to have some bot protection in front of it. It can be worked around by requesting compressed content - github/docs#17358 (comment)

Noticed builds failing to download this script. Docs are updated with a new install path direct from GitHub - https://golangci-lint.run/usage/install/#other-ci
@csainty csainty requested a review from a team as a code owner May 30, 2022 23:52
There seems to be bot protection on docs.github.com which can be bypassed by requesting compressed content - github/docs#17358 (comment)
@csainty csainty changed the title Replace golang-ci install path Fix for failing builds May 31, 2022
Copy link
Contributor

@jamengual jamengual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution

@jamengual jamengual merged commit 591c4da into runatlantis:master Jun 4, 2022
@csainty csainty deleted the patch-1 branch June 7, 2022 00:10
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
* Replace golang-ci install path

Noticed builds failing to download this script. Docs are updated with a new install path direct from GitHub - https://golangci-lint.run/usage/install/#other-ci

* Workaround bot protection on docs.github.com

There seems to be bot protection on docs.github.com which can be bypassed by requesting compressed content - github/docs#17358 (comment)
@nitrocode nitrocode added this to the v0.19.4 milestone Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants