Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker-compose): update docker-compose #2365

Merged

Conversation

casperbiering
Copy link
Contributor

This PR solves two issues.

  1. Currently you need to pass a NGROK_AUTH to ngrok, otherwise you'll get following error when trying to use the connection:
    image

  2. atlantis executable must not be ignored by .dockerignore otherwise docker-compose up and docker build -f Dockerfile.dev . fails with:

[+] Building 1.0s (6/7)
 => [internal] load build definition from Dockerfile.dev 0.0s
 => => transferring dockerfile: 36B 0.0s
 => [internal] load .dockerignore 0.0s
 => => transferring context: 116B 0.0s
 => [internal] load metadata for ghcr.io/runatlantis/atlantis:latest 0.8s
 => [internal] load build context 0.0s
 => => transferring context: 2B 0.0s
 => [1/3] FROM ghcr.io/runatlantis/atlantis:latest@sha256:3765101d3ee2b9db27f140a4766222b400f63d3cb4659d64394bcc6a2eedcec7 0.0s
 => ERROR [2/3] COPY atlantis /usr/local/bin/atlantis 0.0s
------
 > [2/3] COPY atlantis /usr/local/bin/atlantis:
------
failed to solve: failed to compute cache key: "/atlantis" not found: not found

@casperbiering casperbiering requested a review from a team as a code owner July 5, 2022 22:06
@casperbiering casperbiering changed the title fix: docker-compose.yml is not working chore: docker-compose.yml is not working Jul 5, 2022
@casperbiering casperbiering force-pushed the docker-compose-not-working branch from 5117e40 to 3d8ac36 Compare July 5, 2022 22:08
@chenrui333 chenrui333 changed the title chore: docker-compose.yml is not working fix(docker-compose): update docker-compose Jul 7, 2022
@chenrui333 chenrui333 merged commit e81e59c into runatlantis:master Jul 7, 2022
@chenrui333
Copy link
Member

Looks good, thanks @casperbiering!

krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
@nitrocode nitrocode added this to the v0.19.5 milestone Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants