Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add status to the real-time logs page #2426

Merged
merged 3 commits into from
Nov 14, 2022

Conversation

lukemassa
Copy link
Contributor

Sometimes when I open the streaming logs, it's hard to tell if anything is happening, or if it's just hanging because it's waiting for output.

This is a Proof of Concept for adding to the footer the "status" of the terminal, such that once the socket is closed, it says "Done" at the bottom.

From a UI perspective, simply updating html of the footer is not be the cleanest solution, I'm open to suggestions, just wanted to get the idea out there.

@lukemassa lukemassa requested a review from a team as a code owner August 1, 2022 20:36
@lukemassa
Copy link
Contributor Author

We could also add a handler on "error", which would help with situations where the page loads but failed to connect to the websocket (which I see sometimes if you click the link too quickly), at which point the page will never show any output, and it's not unless you look at the console logs and see "WebSocket connection to 'wss://' failed:" that you can tell.

@jamengual jamengual added waiting-on-review Waiting for a review from a maintainer needs discussion Large change that needs review from community/maintainers labels Aug 8, 2022
Copy link
Member

@nitrocode nitrocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @jamengual @chenrui333 please review too.

@nitrocode nitrocode merged commit 752d861 into runatlantis:master Nov 14, 2022
krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
* Add status of the terminal to the footer

* Change function call

Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
@nitrocode nitrocode added this to the 0.21.0 milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs discussion Large change that needs review from community/maintainers waiting-on-review Waiting for a review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants