Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore GitLab Draft MRs #2468

Merged
merged 3 commits into from
Aug 25, 2022
Merged

ignore GitLab Draft MRs #2468

merged 3 commits into from
Aug 25, 2022

Conversation

becjon
Copy link
Contributor

@becjon becjon commented Aug 24, 2022

No description provided.

@becjon becjon requested a review from a team as a code owner August 24, 2022 08:23
@becjon becjon mentioned this pull request Aug 24, 2022
Closed
1 task
@becjon becjon force-pushed the ignore_gitlab_draft_mrs branch from 55bb7bf to f04e172 Compare August 24, 2022 08:33
@becjon
Copy link
Contributor Author

becjon commented Aug 24, 2022

resolves #2467

@jamengual jamengual added the waiting-on-review Waiting for a review from a maintainer label Aug 24, 2022
lilincmu
lilincmu approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@lilincmu lilincmu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than two small nits, this looks good to me. Thanks for your contribution! If you decide not to address the nits, I'll merge this PR later.

server/events/event_parser_test.go Show resolved Hide resolved
server/events/event_parser_test.go Outdated Show resolved Hide resolved
@lilincmu lilincmu merged commit 5bf7c93 into runatlantis:master Aug 25, 2022
@lilincmu lilincmu added feature New functionality/enhancement and removed waiting-on-review Waiting for a review from a maintainer labels Aug 25, 2022
@becjon becjon deleted the ignore_gitlab_draft_mrs branch August 27, 2022 13:09
krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
@becjon @krrrr38
ignore GitLab Draft MRs (runatlantis#2468)
8142818 
* feat: ignore GitLab Draft MRs

* deepcopy and overwrite unit under test

* add tests for close actions
@nitrocode nitrocode added this to the v0.19.9 milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilincmu lilincmu lilincmu approved these changes

Assignees
No one assigned
Labels
feature New functionality/enhancement
Projects
None yet
Milestone
v0.19.9
Development

Successfully merging this pull request may close these issues.
4 participants
@becjon @lilincmu @jamengual @nitrocode