Use proper http client for github v4 api #2479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pulled this into my test environment to test. Thanks for creating this PR @ysoldak! |
jamengual
added
bug
|
FYI we are running on our production a build that has changes from this and sister PR #2480 included. Here is our branch we cherry-pick into: https://github.com/ysoldak/atlantis/commits/nordnet |
|
1 week on prod, all systems nominal. |
lilincmu
approved these changes
Sep 7, 2022
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
* Use proper http client for github v4 api * Remove extra print lines Co-authored-by: Ray Terrill <rayterrill@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative take on GitHub v4 client token refresh issue.
See another approach #2475
Hopefully fixes #2285