-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auto-plan projects when modules change #2507
Conversation
What are the repo structure and the module instantiation used? a more detailed example could help to understand the feature |
@jamengual updated the description to point to the test data. It's layout agnostic as it parses the module dependencies out of the projects. |
so this only works when the |
@jamengual correct, it's only detecting changes to local modules. |
326ffd4
to
e093b18
Compare
Sorry for the churn, in testing this out, I've squashed some bugs and cleaned things up. I think the docs now lay out the use case. Since it's a departure from current behavior, it requires a flag to activate, but I think |
Anything else I need to do to have this considered? A week of using it in our pipelines hasn't revealed any new issues. |
This sounds similar to something I have in my |
@pauloconnor yup! |
@iamnoah Damn, that's fantastic! Hopefully this'll get merged in soon. |
a3dd7f7
to
3785456
Compare
@jamengual rebased and tried to fix linter issues. LMK what can help move this forward. |
@iamnoah please merge from the default branch to fix the |
02dd5dc
to
8c747ab
Compare
@iamnoah can you fix the conflicts? |
# Conflicts: # go.mod # go.sum
@iamnoah please fix conflicts |
# Conflicts: # cmd/server.go # go.sum
@iamnoah please fix linting error in failed branch pr check |
@iamnoah apologies but looks like this PR has some conflicts, could you resolve them? |
# Conflicts: # go.mod # go.sum # server/events/project_finder.go
@iamnoah Thanks for the contribution |
@jamengual what are the chances of getting a release cut with this in it? Looks like the merge happened less than two hours after the release was tagged. |
we do pre-release for new features before they go to the stable branch. We will do a prerelease soon. |
* feat: auto-plan projects when modules change Fixes runatlantis#920 * rename Downstream->Dependent; docs cleanup * chore: gofmt -s
Fixes #920
See testdata for an example repo structure. Any project that uses modules in the same repo should be able to take advantage.
Only files that are not considered part of a project will be considered. With the current auto-plan heuristic, only changed files in
/modules/
without amain.tf
would trigger a check of the modules dependencies.Adds
--autoplan-modules
and--autoplan-modules-from-projects