-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: --silence-no-projects
to comments with -d
and -p
#2969
feat: --silence-no-projects
to comments with -d
and -p
#2969
Conversation
--silence-no-projects
to comments with -d
and -p
I updated the Now the flag locks the server down on defined projects (it will silently ignore anything else) which is backwards-incompatible (the flag hasn't behaved this way until now). Maybe a new flag could be introduced instead but I haven't figured out how to call it. |
@Dawnflash I approved the test runs, can you rebase? |
aa80d1d
to
73dd2bf
Compare
73dd2bf
to
558839d
Compare
a5269a6
to
fab8aaa
Compare
fab8aaa
to
47c56b6
Compare
Thank you for the PR @Dawnflash ! cc @runatlantis/maintainers for another review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks again @Dawnflash for the contribution |
@Dawnflash there seems to be a linting issue. Let's fix that before merging.
|
Oops, I fixed that. |
Thank you again!! This will be available in the |
what
SilenceNoProjects
flag ignore targeted projects (-d
,-p
flags) if no configured projects match the targetSilenceNoProjects
to theimport
command as it is currently lacking itwhy
SilenceNoProjects
flag is effective at silencing non-targeted commands likeatlantis plan
but falls flat with targeted commands likeatlantis plan -d mydir
.-p
and-d
are used in this setup, we only ever want one Atlantis server to handle the commandtests
import
commandreferences