docs: apply home dark mode #3062
Merged
+249
−327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krrrr38
commented
Jan 27, 2023
| $buttonColor: var(--c-brand); | ||
| $buttonHoverColor: var(--c-brand-light); | ||
| $darkBackground: var(--c-bg-light); | ||
| $darkBackgroundBorder: var(--c-border-dark); |
There was a problem hiding this comment.
When using var color, we can apply dark mode easily. All vars are defined in the following.
https://v2.vuepress.vuejs.org/reference/default-theme/styles.html#style-file
jamengual
approved these changes
Jan 27, 2023
|
@krrrr38 nice work! And thank you for the contribution! could you add |
krrrr38
force-pushed
the
fix-docs-home-dark-mode
branch
from
9a093b3 to
a101303
Compare
krrrr38
force-pushed
the
fix-docs-home-dark-mode
branch
from
d806a34 to
e9edbd2
Compare
nitrocode
approved these changes
Jan 27, 2023
DragosDumitrache
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Jan 30, 2023
* merge scss into index.scss * apply darkmode on docs Home using predefined var color * codeql/labeler github action for handling draft pr * labeler require pull_requiest_target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
Doc top page doesn't apply dark mode correctly.
tests
references