Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix import/state rm success wrapped template #3084

Merged

Conversation

krrrr38
Copy link
Contributor

@krrrr38 krrrr38 commented Jan 31, 2023

what

server/events/templates/import_success_wrapped.tmpl and server/events/templates/state_rm_success_wrapped.tmpl wrap templates are not processed correctly (others are correct like followings).

✘╹◡╹✘☆  ag -A1 '<details><summary>Show Output</summary>' server/events/templates/
server/events/templates/import_success_wrapped.tmpl
2:<details><summary>Show Output</summary>
3-```diff

server/events/templates/policy_check_success_wrapped.tmpl
2:<details><summary>Show Output</summary>
3-

server/events/templates/wrapped_err.tmpl
3:<details><summary>Show Output</summary>
4-

server/events/templates/plan_success_wrapped.tmpl
2:<details><summary>Show Output</summary>
3-

server/events/templates/state_rm_success_wrapped.tmpl
2:<details><summary>Show Output</summary>
3-```diff

server/events/templates/version_wrapped_success.tmpl
2:<details><summary>Show Output</summary>
3-

server/events/templates/apply_wrapped_success.tmpl
2:<details><summary>Show Output</summary>
3-

why

When import/state rm result are too log, the comments are not wrapped correctly.

krrrr38/atlantis-debug#11 (comment)

tests

before ```diff not wrapped correctly without empty line ```
after
wrapped correctly with empty line

references

@krrrr38 krrrr38 requested a review from a team as a code owner January 31, 2023 07:24
@nitrocode nitrocode added this to the v0.23.0 milestone Jan 31, 2023
Copy link
Member

@nitrocode nitrocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nitrocode nitrocode merged commit 48b18f9 into runatlantis:main Jan 31, 2023
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants