Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docker): download transitive dependencies #3107

Merged
merged 1 commit into from
Feb 7, 2023
Merged

feat(docker): download transitive dependencies #3107

merged 1 commit into from
Feb 7, 2023

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Feb 7, 2023 •
edited
Loading

what

  • download transitive dependencies

why

  • faster docker builds due to downloading dependencies instead of compiling them
  • builds are usually 26 minutes

tests

  • I have tested my changes by checking build time in pr checks

references

@nitrocode nitrocode requested a review from a team as a code owner February 7, 2023 04:56
@github-actions github-actions bot added the build Relating to how we build Atlantis label Feb 7, 2023
@nitrocode nitrocode enabled auto-merge (squash) February 7, 2023 06:00
@nitrocode nitrocode merged commit a6c09f7 into main Feb 7, 2023
@nitrocode nitrocode deleted the go-get-transitive-dependencies branch February 7, 2023 06:16
@nitrocode nitrocode added this to the v0.23.0 milestone Feb 9, 2023
@albertorm95 albertorm95 mentioned this pull request May 19, 2023
Merged
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@nitrocode @ijames-gc
feat(docker): download transitive dependencies (runatlantis#3107)
a04e0d7
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@nitrocode @ijames-gc
feat(docker): download transitive dependencies (runatlantis#3107)
495446d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

Assignees
No one assigned
Labels
build Relating to how we build Atlantis
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nitrocode @jamengual