feat: Add GitLab Reaction Emojis on MR Comments #3456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs
|
This PR is ready for review. |
mtavaresmedeiros
pushed a commit
to mtavaresmedeiros/atlantis
that referenced
this pull request
Jul 3, 2023
* Add GitLab Reaction Emoji * Update docs * update docs * Update event_parser_test
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
* Add GitLab Reaction Emoji * Update docs * update docs * Update event_parser_test
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
* Add GitLab Reaction Emoji * Update docs * update docs * Update event_parser_test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Adds reaction emojis to Atlantis command comments on GitLab merge requests.
ReactToCommentfunction with a call tog.Client.AwardEmoji.CreateMergeRequestAwardEmojiOnNoteMergeRequestIID(pullNum) andNoteID(commentID) properties for the call.pullNumwas not currently being passed to theReactToCommentfunction so this has been added to all the VCSReactToCommentfunctions and calls.commentIDhas been added as an output ofParseGitlabMergeRequestCommentEvent.Missing documentation for the
emoji-reactionproperty has also been added.why
Bring Atlantis GitLab VCS support more inline with the GitHub VCS support.
tests
No
emoji-reactionpropertythumbsupemoji-reactionpropertyreferences