Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update Lock Index Page to Use a CSS Grid Layout #3509

Merged
merged 4 commits into from
Jun 12, 2023
Merged

feat: Update Lock Index Page to Use a CSS Grid Layout #3509

merged 4 commits into from
Jun 12, 2023

Conversation

X-Guardian
Copy link
Contributor

what

Update the lock index page to use a CSS grid layout with the following changes:

  • Increase container max-width by 200px
  • Add header row
  • Add row hover highlighting and pointer cursor
  • Standardise font size, weighting and letter spacing
  • Allow word-break anywhere in the repo name and project path.

why

Improves the page display on narrower browser windows and longer repository names/project paths.

tests

Wide Window

image

Narrow Window

image

Mobile Window

image

references

@X-Guardian X-Guardian requested a review from a team as a code owner June 11, 2023 11:19
@github-actions github-actions bot added the go Pull requests that update Go code label Jun 11, 2023
@nitrocode nitrocode added this to the v0.24.3 milestone Jun 11, 2023
nitrocode
nitrocode approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@nitrocode nitrocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again for the nice contribution!

@nitrocode nitrocode merged commit c5d03ed into runatlantis:main Jun 12, 2023
mtavaresmedeiros pushed a commit to mtavaresmedeiros/atlantis that referenced this pull request Jul 3, 2023
@X-Guardian
feat: Update Lock Index Page to Use a CSS Grid Layout (runatlantis#3509)
6ebe2f4 
* Update Lock Index Page to Use a CSS Grid Layout

* Update styles

* Modify css
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@X-Guardian @ijames-gc
feat: Update Lock Index Page to Use a CSS Grid Layout (runatlantis#3509)
d2d37ca 
* Update Lock Index Page to Use a CSS Grid Layout

* Update styles

* Modify css
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@X-Guardian @ijames-gc
feat: Update Lock Index Page to Use a CSS Grid Layout (runatlantis#3509)
f526e08 
* Update Lock Index Page to Use a CSS Grid Layout

* Update styles

* Modify css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

Assignees
No one assigned
Labels
go Pull requests that update Go code
Projects
None yet
Milestone
v0.24.3
Development

Successfully merging this pull request may close these issues.

Lock Index Web Page does not Flow Well on Smaller Browser Windows
2 participants
@X-Guardian @nitrocode