Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable markdown folding on gitlab < 11.1 #366

Merged
merged 2 commits into from
Nov 30, 2018
Merged

Disable markdown folding on gitlab < 11.1 #366

merged 2 commits into from
Nov 30, 2018

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Nov 29, 2018

On startup, make a call to the /version endpoint of Gitlab to get which
version we're running. Then use that version to determine whether we
should use the markdown folding syntax where the code is expandable.
Versions of Gitlab < 11.1 don't support the "Common Mark" markdown
format.

Fixes #315

@codecov
Copy link

codecov bot commented Nov 29, 2018

Codecov Report

Merging #366 into master will decrease coverage by 0.05%.
The diff coverage is 43.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
- Coverage    70.6%   70.54%   -0.06%     
==========================================
  Files          61       61              
  Lines        3681     3718      +37     
==========================================
+ Hits         2599     2623      +24     
- Misses        901      908       +7     
- Partials      181      187       +6
Impacted Files Coverage Δ
server/events/markdown_renderer.go 92.77% <100%> (+0.17%) ⬆️
server/server.go 66.01% <33.33%> (+3.32%) ⬆️
server/events/vcs/gitlab_client.go 20.4% <42.55%> (+20.4%) ⬆️
server/logging/simple_logger.go 84.28% <0%> (+1.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09ecb27...ba04564. Read the comment docs.

On startup, make a call to the /version endpoint of Gitlab to get which
version we're running. Then use that version to determine whether we
should use the markdown folding syntax where the code is expandable.
Versions of Gitlab < 11.1 don't support the "Common Mark" markdown
format.

Fixes #315
@lkysow lkysow merged commit 01aca29 into master Nov 30, 2018
@lkysow lkysow deleted the gitlab-version branch November 30, 2018 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant