Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project name to comments #373

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Add project name to comments #373

merged 1 commit into from
Dec 4, 2018

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Dec 4, 2018

If projects are configured using an atlantis.yaml with a specific
project name, include that in the output for comments. This is useful
because often the project names are better identifiers than the
directory and workspace names and also because some projects use the
same dir and workspace so the only way to differentiate them is via
their names.

Fixes #353

If projects are configured using an atlantis.yaml with a specific
project name, include that in the output for comments. This is useful
because often the project names are better identifiers than the
directory and workspace names and also because some projects use the
same dir and workspace so the only way to differentiate them is via
their names.

Fixes #353
@lkysow lkysow force-pushed the project-name-comments branch from 71fd773 to 934b51b Compare December 4, 2018 18:01
@codecov
Copy link

codecov bot commented Dec 4, 2018

Codecov Report

Merging #373 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #373      +/-   ##
=========================================
+ Coverage   70.25%   70.3%   +0.05%     
=========================================
  Files          62      62              
  Lines        3735    3742       +7     
=========================================
+ Hits         2624    2631       +7     
  Misses        923     923              
  Partials      188     188
Impacted Files Coverage Δ
server/events/project_result.go 100% <ø> (ø) ⬆️
server/events/markdown_renderer.go 92% <100%> (+0.1%) ⬆️
server/events/models/models.go 89.61% <100%> (+0.56%) ⬆️
server/events/project_command_runner.go 81.74% <100%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9adb7eb...934b51b. Read the comment docs.

@lkysow lkysow merged commit 284fa2e into master Dec 4, 2018
@lkysow lkysow deleted the project-name-comments branch December 4, 2018 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant