Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Failing CI after renovate merge #3748

Merged

Conversation

lukemassa
Copy link
Contributor

@lukemassa lukemassa commented Sep 7, 2023

This reverts commit 3a2a244.

what

Reverts 3a2a244, which is causing CI to fail.

why

The commit is causing CI to fail: 3a2a244. I noticed it in a PR I put together earlier https://github.com/runatlantis/atlantis/actions/runs/6105174690/job/16568271076?pr=3747

I'm not totally sure why this is happening, but I figure it should be reverted so other PRs can start passing

tests

Locally if I run make test on main I get:

...
FAIL	github.com/runatlantis/atlantis/server/events [build failed]
...

On this branch I get:

...
ok  	github.com/runatlantis/atlantis/server/events	25.854s
...

references

@lukemassa lukemassa requested a review from a team as a code owner September 7, 2023 04:07
@github-actions github-actions bot added dependencies PRs that update a dependency file go Pull requests that update Go code provider/github labels Sep 7, 2023
Copy link
Contributor

@jamengual jamengual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lukemassa

@jamengual jamengual merged commit 70c9f17 into runatlantis:main Sep 7, 2023
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies PRs that update a dependency file go Pull requests that update Go code provider/github
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants