fix: properly render 🚮 in default templates (cherry-pick #4044) #4049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcp-cherry-pick-bot[bot]](https://avatars.githubusercontent.com/in/169664?s=60&v=4){kind=small}
GenPage
approved these changes
Dec 13, 2023
It seems that GitHub has changed its Markdown renderer such that an emoji followed by a string of plain text (with no other formatting) followed by a colon at the end of the line renders as plain text instead of as the emoji. Compare the following two lines: * 🚮 To delete all plans and locks for the PR, comment: * 🚮 To **delete** all plans and locks for the PR, comment: While this seems like it is probably a GitHub bug, we can work around it by adding some formatting between the emoji and the end of the line, which matches the bullet point above it anyway.
lukemassa
force-pushed
the
cherry-pick-0c5d97-release-0.27
branch
from
ba0a2cd to
6535bf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked Fix rendering of 🚮 in default templates (#4044)
It seems that GitHub has changed its Markdown renderer such that an
emoji followed by a string of plain text (with no other formatting)
followed by a colon at the end of the line renders as plain text instead
of as the emoji. Compare the following two lines:
🚮 To delete all plans and locks for the PR, comment:
🚮 To delete all plans and locks for the PR, comment:
While this seems like it is probably a GitHub bug, we can work around it
by adding some formatting between the emoji and the end of the line,
which matches the bullet point above it anyway.