Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update vuepress to v2.0.0-rc.0 #4102

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

lukemassa
Copy link
Contributor

what

Updated dependencies vuepress and @vuepress/plugin-docsearch from 2.0.0-beta.66 to 2.0.0-rc.0.

why

There are two open PRs from renovate attempting to make these changes:
#3962
#3970

However, they are both failing on CI:
https://github.com/runatlantis/atlantis/actions/runs/7339572431/job/19984042669?pr=3962
https://github.com/runatlantis/atlantis/actions/runs/7339571043/job/19984040138?pr=3970

with the following error:

✖ Rendering 40 pages - failed in 54ms
Error: usePageLang() is called without provider.

Researching a bit, it seems like the reason is that the renovate PRs were updating one of these packages at a time. If you update both (as this PR does) you don't get the error: https://vuepress-theme-hope.github.io/v2/faq/common-error.html#usexxx-is-called-without-provider

tests

Ran yarn locally

references

https://vuepress-theme-hope.github.io/v2/faq/common-error.html#usexxx-is-called-without-provider
#3962
#3970

@lukemassa lukemassa requested review from a team as code owners December 27, 2023 15:44
@lukemassa lukemassa requested review from GenPage, nitrocode and X-Guardian and removed request for a team December 27, 2023 15:44
@github-actions github-actions bot added dependencies PRs that update a dependency file website labels Dec 27, 2023
@GenPage GenPage enabled auto-merge (squash) December 27, 2023 16:11
@GenPage GenPage merged commit 7cd43e1 into runatlantis:main Dec 27, 2023
23 checks passed
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies PRs that update a dependency file website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants