chore: Add missing flag test for DisableGlobalApplyLockFlag #4183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemassa
requested review from
jamengual,
nitrocode and
X-Guardian
and removed request for
a team
lukemassa
force-pushed
the
add_missing_flag_test
branch
from
77ef38f to
6b013cf
Compare
jamengual
approved these changes
Jan 29, 2024
GenPage
approved these changes
Jan 29, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Add entry to testFlags for DisableGlobalApplyLockFlag
why
Should be done for all new flags.
Note: This is too easy to happen by accident at this point, I am working on preventing these issues: #4063
tests
Ran CI
references
New flag introduced in: #4158